Re: walprotocol.h vs frontends

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: walprotocol.h vs frontends
Date: 2011-08-16 12:58:19
Message-ID: CA+U5nMJJqn92yfZXupZPDBUvyWVjg9+6VauOB1sV+PLYui77Tw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 16, 2011 at 9:35 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:

>> So right now what we do is allow a single packet to span multiple
>> files, but since MAX_SEND_SIZE is 128KB it will always be smaller than
>> a single file, so we can only ever span two files at most.
>
> Unless someone has tweaked their xlog segment size to insane values.

We should limit MAX_SEND_SIZE to be same or less than WAL_SEGMENT_SIZE.

We gain nothing by continuing to allow the existing code to work in
the way it does.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2011-08-16 13:19:14 Re: WIP: Fast GiST index build
Previous Message Simon Riggs 2011-08-16 12:54:45 Re: pg_stat_replication vs StandbyReplyMessage