From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Florian Pflug <fgp(at)phlo(dot)org>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: plpgsql.warn_shadow |
Date: | 2014-01-26 22:24:14 |
Message-ID: | CA+U5nMJ0rvXqa2CS1kdm71ZmPzquzTQ1R42hi9w3AQO_35Gt8w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 26 January 2014 15:53, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
>
>
> 2014-01-26 Florian Pflug <fgp(at)phlo(dot)org>
>
>> On Jan26, 2014, at 10:19 , Simon Riggs <simon(at)2ndQuadrant(dot)com> wrote:
>> > Also, having
>> > plpgsql.warnings_as_errors = off (default) | on
>> > makes sense and should be included in 9.4
>>
>> I still think this is a bad idea, for the same reasons I don't like
>> consistent_into (discussed in a separate thread).
>>
>> But these objections would go away if restricted this to function
>> creation time only. So even with warnings_as_errors=on, you
>> could still *call* a function that produces a warning, but not
>> *create* one.
>
>
> +1 behave - and please, better name
+1 to that.
I guess I only saw that way of working because I was thinking of it as
a "compiler warning".
So perhaps we should call it
plpgsql.compiler_warnings_as_errors
to make that behaviour more clear.
plpgsql.error_on_create_warnings
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2014-01-26 22:42:20 | jsonb and nested hstore |
Previous Message | Andrew Dunstan | 2014-01-26 22:23:32 | Re: [patch] Client-only installation on Windows |