| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Markus Wanner <markus(at)bluegap(dot)ch>, kaigai(at)kaigai(dot)gr(dot)jp, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: Extra Daemons / bgworker |
| Date: | 2012-12-05 21:46:03 |
| Message-ID: | CA+U5nM+V1WygfmAn7fyRNhQu9RdUgH7188DNWROGy0dvK=C+uA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5 December 2012 15:09, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Here's a first attempt at a new documentation chapter. This goes in
> part "Server Programming", just after the SPI chapter.
>
> I just noticed that worker_spi could use some more sample code, for
> example auth_counter was getting its own LWLock and also its own shmem
> area, which would be helpful to demonstrate I think.
"to run once" -> "to run when"
Prefer
BgWorkerStart_ConsistentState to be renamed to BgWorkerRun_InHotStandby
BgWorkerStart_RecoveryFinished to be renamed to BgWorkerRun_InNormalMode
presumably a process will shutdown if (BgWorkerRun_InHotStandby &&
!BgWorkerRun_InNormalMode)
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-12-05 21:56:52 | Re: PITR potentially broken in 9.2 |
| Previous Message | Alvaro Herrera | 2012-12-05 21:42:42 | Re: Review: Extra Daemons / bgworker |