| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Robert Haas <rhaas(at)postgresql(dot)org> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Make it easy to detach completely from shared memory. |
| Date: | 2014-03-18 12:41:34 |
| Message-ID: | CA+U5nM+=JX3onM2a+05+BAK6fOshhOsUmsquUpv2kx65_RFMRg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 18 March 2014 11:59, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> Make it easy to detach completely from shared memory.
>
> The new function dsm_detach_all() can be used either by postmaster
> children that don't wish to take any risk of accidentally corrupting
> shared memory; or by forked children of regular backends with
> the same need. This patch also updates the postmaster children that
> already do PGSharedMemoryDetach() to do dsm_detach_all() as well.
>
> Per discussion with Tom Lane.
I think we need to document exactly why dsm_detach_all() isn't simply
part of PGSharedMemoryDetach() ?
Having two calls seems like a recipe for error in core and extensions.
Perhaps we should consider a parameter for PGSharedMemoryDetach() ?
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-03-18 13:09:08 | Re: [COMMITTERS] pgsql: Make it easy to detach completely from shared memory. |
| Previous Message | Fujii Masao | 2014-03-18 12:21:16 | pgsql: Fix help message and document in pg_receivexlog. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2014-03-18 12:43:48 | Re: plpgsql.warn_shadow |
| Previous Message | Fujii Masao | 2014-03-18 12:38:06 | Re: HEAD seems to generate larger WAL regarding GIN index |