Re: [PATCH] Unremovable tuple monitoring (was: Addition of some trivial auto vacuum logging)

On Mon, Oct 3, 2011 at 9:17 AM, Royce Ausburn <royce(dot)ml(at)inomial(dot)com> wrote:
> - I'm not sure if I'm supposed to update CATALOG_VERSION_NO in catalog.h.  In this patch I have.

Generally that is left to the committer, as the correct value depends
on the value at the time of commit, not the time you submit the patch;
and including it in the patch tends to result in failing hunks, since
the value changes fairly frequently.

> - I'm not sure about how I should be selecting an OID for my new stats function.  I used the unused_oids script and picked one that seemed reasonable.

That's the way to do it.

> - The VACUUM FULL implementation in cluster.c doesn't do any stats updating similar to vacuumlazy.c, so I haven't don't anything there… (is this right?  A vacuum full may also encounter unremovable tuples, right?)

We've occasionally heard grumblings about making cluster do more stats
updating, but your patch should just go along with whatever's being
done now in similar cases.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company