| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Phil Currier <pcurrier(at)gmail(dot)com> |
| Subject: | Re: 9.5 release scheduling (was Re: logical column ordering) |
| Date: | 2014-12-11 21:04:10 |
| Message-ID: | CA+TgmobrKz-BiSOGSpbF+HW6Dh6EH2FogzywQRwK4unN6b4qxg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 11, 2014 at 3:47 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> I agree. Having your patch disappear into the void is not friendly at all.
> But I don't think a commentless "-1" is the answer, either. That might one
> of the few things worse than silence. Even if the comment is just "This
> seems awfully complicated for a minimally useful feature" or "This will
> probably have unintended side effects in the executor that I don't have time
> to trace down, can someone make an argument for correctness", or even "this
> format is unreadable, I won't review this until it is fixed" then at least
> the author (and perhaps more important, junior contributors who are not the
> author) will know either what argument to make to lobby for it, what avenue
> to take when reviewing it, or whether to just forget it and work on
> something more important.
Agreed!
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-12-11 21:05:49 | Re: 9.5 release scheduling (was Re: logical column ordering) |
| Previous Message | Jeff Janes | 2014-12-11 20:47:38 | Re: 9.5 release scheduling (was Re: logical column ordering) |