Re: Event Triggers: adding information

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Event Triggers: adding information
Date: 2013-01-23 03:01:43
Message-ID: CA+Tgmobn7g04hpybaHoDFGzeqE_nfRwYgHWk_5RoA+k2frG1pg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 22, 2013 at 7:02 AM, Dimitri Fontaine
<dimitri(at)2ndquadrant(dot)fr> wrote:
> I had to make quiet a part of the regression tests because of the ERROR
> message containing an OID, where I think it's the right error message.

I have a feeling that's the sort of error message that we don't want
people to get. Can we arrange for something cleaner? Not sure
exactly what. Maybe something like this would do it:

ERROR: queued event trigger function not found

Or maybe we should just silently ignore failures to look up the event
trigger. That might be better, because the DBA could always do:

DROP FUNCTION myeventtrgfn() CASCADE;

...and it would be undesirable for other sessions to error out in that
case due to SnapshotNow effects.

> I don't think we want to add complexity to the code to be able to report
> the procedure name that we depend on in the event cache and that the
> user just deleted while in the middle of actually running the event
> trigger list we already got from the cache, right?

Yeah ... that seems like more code than the situation justifies.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-01-23 03:02:42 Re: Event Triggers: adding information
Previous Message Robert Haas 2013-01-23 02:55:14 Re: Event Triggers: adding information