| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Anssi Kääriäinen <anssi(dot)kaariainen(at)thl(dot)fi>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
| Subject: | Re: tracking commit timestamps |
| Date: | 2014-12-03 16:08:03 |
| Message-ID: | CA+TgmobVyvGML-9Sc0TxGxKSigBtKzCWpuvpMtMB4PEsLqHzng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On Mon, Dec 1, 2014 at 5:34 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> I made two more changes:
> 1. introduce newestCommitTs. Original code was using lastCommitXact to
> check that no "future" transaction is asked for, but this doesn't really
> work if a long-running transaction is committed, because asking for
> transactions with a higher Xid but which were committed earlier would
> raise an error.
I'm kind of disappointed that, in spite of previous review comments,
this got committed with extensive use of the CommitTs naming. I think
that's confusing, but it's also something that will be awkward if we
want to add other data, such as the much-discussed commit LSN, to the
facility.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-12-03 16:11:49 | Re: Removing INNER JOINs |
| Previous Message | Andres Freund | 2014-12-03 15:56:20 | Re: Removing INNER JOINs |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-12-03 18:11:32 | Re: tracking commit timestamps |
| Previous Message | Petr Jelinek | 2014-12-03 14:58:52 | Re: tracking commit timestamps |