| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: WAL format changes |
| Date: | 2012-06-18 18:00:11 |
| Message-ID: | CA+TgmobG9VWWvLXeK0XOxoWXtza8JTFgSu2eoAtVFucxH6gLBw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 14, 2012 at 5:58 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> 1. Use a 64-bit segment number, instead of the log/seg combination. And
>> don't waste the last segment on each logical 4 GB log file. The concept
>> of a "logical log file" is now completely gone. XLogRecPtr is unchanged,
>> but it should now be understood as a plain 64-bit value, just split into
>> two 32-bit integers for historical reasons. On disk, this means that
>> there will be log files ending in FF, those were skipped before.
> Whats the reason for keeping that awkward split now? There aren't that many
> users of xlogid/xcrecoff and many of those would be better served by using
> helper macros.
I wondered that, too. There may be a good reason for keeping it split
up that way, but we at least oughta think about it a bit.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2012-06-18 18:08:14 | Re: WAL format changes |
| Previous Message | Alvaro Herrera | 2012-06-18 17:46:10 | Re: [PATCH] lock_timeout and common SIGALRM framework |