Re: Patch: add timing of buffer I/O requests

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Ants Aasma <ants(at)cybertec(dot)at>
Cc: Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch: add timing of buffer I/O requests
Date: 2012-03-27 18:58:39
Message-ID: CA+Tgmob7RKS-Q1-25aQ1B95n8WAQijEtviUbUqPkS41GMAR7NQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 22, 2012 at 7:38 PM, Ants Aasma <ants(at)cybertec(dot)at> wrote:
> On Wed, Mar 21, 2012 at 5:01 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> This seems to have bitrotted again.  :-(
>>
>> Can you please rebase again?
>
> Rebased.

I've committed the core of this. I left out the stats collector
stuff, because it's still per-table and I think perhaps we should back
off to just per-database. I changed it so that it does not conflate
wait time with I/O time. Maybe there should be a separate method of
measuring wait time, but I don't think it's a good idea for the
per-backend stats to measure a different thing than what gets reported
up to the stats collector - we should have ONE definition of each
counter. I also tweaked the EXPLAIN output format a bit, and the
docs.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2012-03-27 19:14:32 Re: Cross-backend signals and administration (Was: Re: pg_terminate_backend for same-role)
Previous Message Peter Geoghegan 2012-03-27 18:47:06 Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)