| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com>, Ian Barwick <ian(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Jim Nasby <jim(at)nasby(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Subject: | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Date: | 2014-12-08 17:31:53 |
| Message-ID: | CA+Tgmoayvd0sHd8WnLm1NAR7+BwbRE5TB-L59AJtGBZYGX4rvQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 5, 2014 at 3:45 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Fri, Dec 5, 2014 at 12:33 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> Well, if an alias is used, and you refer to an attribute using a
>>> non-alias name (i.e. the original table name), then you'll already get
>>> an error suggesting that the alias be used instead -- of course,
>>> that's nothing new. It doesn't matter to the existing hinting
>>> mechanism if the attribute name is otherwise wrong. Once you fix the
>>> code to use the alias suggested, you'll then get this new
>>> Levenshtein-based hint.
>>
>> In that case, I think I favor giving no hint at all when the RTE name
>> is specified but doesn't match exactly.
>
> I don't follow. The existing mechanism only concerns what to do when
> the original table name was used when an alias should have been used
> instead. What does that have to do with this patch?
Just that that's the case in which it seems useful to give a hint.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-12-08 17:39:45 | Re: alter user set local_preload_libraries. |
| Previous Message | Ronan Dunklau | 2014-12-08 15:21:37 | Dumping database creation options and ACLs |