| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reviewing freeze map code |
| Date: | 2016-06-06 14:03:57 |
| Message-ID: | CA+TgmoawroBErktkYOSGDYcAQ14JbH22MpGGprUQc=W8aVLWMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 6, 2016 at 7:46 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Jun 4, 2016 at 12:18 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> Attached updated patch.
>
> The error-checking enhancements here look good to me, except that you
> forgot to initialize totalBytesRead. I've committed those changes
> with a fix for that problem and will look at the rest of this
> separately.
Committed that now, too.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-06-06 14:06:09 | Re: Reviewing freeze map code |
| Previous Message | Merlin Moncure | 2016-06-06 13:59:46 | Re: Relax requirement for INTO with SELECT in pl/pgsql |