| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: Sharing record typmods between backends |
| Date: | 2017-08-23 13:45:38 |
| Message-ID: | CA+TgmoawEK_JWbPATxtQu1jcwxjRu8HhvOAQofD-SpNZ3s_EOw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 23, 2017 at 1:46 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> For later commits in the series:
> - Afaict the whole shared tupledesc stuff, as tqueue.c before, is
> entirely untested. This baffles me. See also [1]. I can force the code
> to be reached with force_parallel_mode=regress/1, but this absolutely
> really totally needs to be reached by the default tests. Robert?
force_parallel_mode=regress is a good way of testing this because it
keeps the leader from doing the work, which would likely dodge any
bugs that happened to exist. If you want to test something in the
regular regression tests, using force_parallel_mode=on is probably a
good way to do it.
Also note that there are 3 buildfarm members that test with
force_parallel_mode=regress on a regular basis, so it's not like there
is no automated coverage of this area.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-08-23 13:59:47 | Re: Pluggable storage |
| Previous Message | Peter Eisentraut | 2017-08-23 13:40:59 | Re: locale problem of bgworker: logical replication launcher and worker process |