Re: [v9.2] DROP statement reworks

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [v9.2] DROP statement reworks
Date: 2011-10-03 16:20:15
Message-ID: CA+TgmoapuO8C-qYrsRMbR9jJZCTW-2f30TBmhrWHq3WzSJAhfw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 3, 2011 at 11:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Mon, Oct 3, 2011 at 10:54 AM, Dimitri Fontaine
>> <dimitri(at)2ndquadrant(dot)fr> wrote:
>>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>> I think that new versions of patch can handle unified diffs without a
>>>> problem, but older versions choke on them.  My Mac has 2.5.8 and
>>>> handles unidiffs no problem.
>
>>> Even containing git headers?
>
>> Yeah, it just skips right over them.  I've never had even a minor
>> problem on that account, which is why I was surprised to see it giving
>> you so much trouble.
>
> I haven't observed any such problems even with the rather ancient copy
> of GNU patch on my HPUX box (seems to be 2.5.4, released in 1999).
> I vaguely recall having had to replace the even older vendor-supplied
> patch because that one didn't do unidiffs ...

I have seen unified diffs blow up when using patch on a fairly new
HP-UX box, but I'm not sure whether I'm using an OS-supplied copy of
patch or something someone installed along the line somewhere.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-10-03 16:25:21 Re: Should we get rid of custom_variable_classes altogether?
Previous Message Robert Haas 2011-10-03 16:10:39 Re: Should we get rid of custom_variable_classes altogether?