Re: Review: UNNEST (and other functions) WITH ORDINALITY

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>
Subject: Re: Review: UNNEST (and other functions) WITH ORDINALITY
Date: 2013-07-24 17:31:50
Message-ID: CA+TgmoaobK-mwLWQGQ87E-4fPN8W-RwgmBwSz5CusYr7uK+yzg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 23, 2013 at 9:38 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> If it weren't that we've been speculating for years about deprecating
> SRFs-in-tlists once we had LATERAL, I would personally consider this
> patch DOA in this form. If we do think we'll probably deprecate that
> feature, then not extending WITH ORDINALITY to such cases is at least
> defensible. On the other hand, considering that we've yet to ship a
> release supporting LATERAL, it's probably premature to commit to such
> deprecation --- we don't really know whether people will find LATERAL
> to be a convenient and performant substitute.

I guess I'd sort of assumed that the plan was to continue accepting
SRFs in tlists but rewrite them as lateral joins, rather than getting
rid of them altogether. IIUC that would simplify some things inside
the executor. I'd be a bit more reluctant to just ban SRFs in target
lists outright.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-07-24 17:36:39 Re: Review: UNNEST (and other functions) WITH ORDINALITY
Previous Message Robert Haas 2013-07-24 17:03:36 Re: Design proposal: fsync absorb linear slider