| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>, Pavel Golub <pavel(at)gf(dot)microolap(dot)com>, Pavel Golub <pavel(at)microolap(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pavel Stěhule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: Fwd: Proposal: variant of regclass |
| Date: | 2014-04-08 15:37:31 |
| Message-ID: | CA+Tgmoaj-tM1vpt16-p01Ymtz6qiZwDUTnekcuEDafBUYLLVcg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 8, 2014 at 11:01 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Apr 8, 2014 at 10:50 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Looks good, committed with a bit of further cleanup.
>>
>> I had not actually paid attention to the non-regclass parts of this, and
>> now that I look, I've got to say that it seems borderline insane to have
>> chosen to implement regproc/regoper rather than regprocedure/regoperator.
>> The types implemented here are incapable of dealing with overloaded names,
>> which --- particularly in the operator case --- makes them close to
>> useless. I don't think this code was ready to commit.
>
> Well, I noticed that, too, but I didn't think it was my job to tell
> the patch author what functions he should have wanted. A follow-on
> patch to add to_regprocedure and to_regoperator wouldn't be much work,
> if you want that.
And here is a patch for that.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| to-regoperator-and-regprocedure.patch | text/x-patch | 14.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-04-08 15:45:34 | Re: Dynamic Shared Memory stuff |
| Previous Message | Pavel Stehule | 2014-04-08 15:37:14 | Re: four minor proposals for 9.5 |