Re: [v9.2] DROP statement reworks

On Sun, Oct 2, 2011 at 4:08 PM, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> Ok I needed `git apply' to apply the patches, now that I used that I can
> confirm that the 3 patches apply, compile, pass tests, and that I could
> play with them a little.  I think I'm going to mark that ready for
> commiter.  I don't have enough time for a more deep review but at the
> same time patch reading and testing both passed :)
>
> You might need to post a version that patch will be happy with, though,
> using e.g.
>
>  git diff |filterdiff --format=context > /tmp/foo.patch
>
> Then diffstat reports:
>  35 files changed, 932 insertions(+), 1913 deletions(-), 345 modifications(!)

I think that new versions of patch can handle unified diffs without a
problem, but older versions choke on them. My Mac has 2.5.8 and
handles unidiffs no problem.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company