Re: background worker and normal exit

On Tue, May 28, 2013 at 10:31 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2013-05-28 10:23:46 -0400, Robert Haas wrote:
>> On Sun, May 26, 2013 at 6:48 PM, Michael Paquier
>> > - set bgw_restart_time to BGW_NEVER_RESTART. and have the bgworler exit with
>> > non-0 status code.
>>
>> That might be good enough, though.
>
> I suggested that to Fujii at pgcon, and it seems to work for him. But I
> think this sucks since you loose support for a restart upon a FATAL or
> similar error. And you cannot mark that as something non-fatal in the
> log. To this day I laugh about the following oddity in the xorg log:
>
> [ 30.087] (II) RADEON(0): RandR 1.2 enabled, ignore the following RandR disabled message.
> [ 30.088] (--) RandR disabled
>
> I really don't want to go there.
>
> You actually can only return a 1 since everything else will tear down
> the whole cluster...
>
> We actually were discussing this recently:
> http://archives.postgresql.org/message-id/20130423134833.GD8499%40alap2.anarazel.de
>
> I think a separate return code for "exited gracefully, don't restart"
> would be a good idea.

Yeah. Or maybe the restart-timing/restart-when logic should just
apply to the exit(0) case as well. Not sure what the downside of that
would be.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company