Re: Patch: add psql tab completion for event triggers

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Ian Barwick <ian(at)2ndquadrant(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: add psql tab completion for event triggers
Date: 2014-04-14 12:46:59
Message-ID: CA+TgmoaW2YYa_Fh=OvEZaRHrLQLHnJ7qfM7vtDFfmv6H6aOzuw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 9, 2014 at 8:58 PM, Ian Barwick <ian(at)2ndquadrant(dot)com> wrote:
> Apologies again, that was ill-thought out. Revised patch attached with only
> the additions related to event triggers, and the small fix for ALTER TRIGGER
> mentioned above which ensures "RENAME TO" is applied only when "ALTER
> TRIGGER <name> ON <sth>" was input; currently there is no check for a
> preceding "ALTER", resulting in the spurious "RENAME TO" when completing
> "CREATE EVENT TRIGGER".

OK, committed.

(I know this was submitted rather late, but I think we've often
allowed tab-completion fixups at similar times in past releases, since
they are quite mechanical. If anyone feels that I shouldn't have
committed this, please advise.)

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-04-14 12:57:27 Re: four minor proposals for 9.5
Previous Message Ivan Voras 2014-04-14 12:01:19 Re: CLOB & BLOB limitations in PostgreSQL