| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE |
| Date: | 2011-07-07 18:43:22 |
| Message-ID: | CA+TgmoaUAgevL-wRcn2OcgOLjdUS8UJHyb6tbENKkL5UETp9TA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 6, 2011 at 2:50 PM, Noah Misch <noah(at)2ndquadrant(dot)com> wrote:
> Drat; fixed in this version. My local branches contain a large test battery
> that I filter out of the diff before posting. This time, that filter also
> removed an essential part of the patch.
OK, I'm pretty happy with this version, with the following minor caveats:
1. I still think the documentation changes could use some
word-smithing. If I end up being the one who commits this, I'll take
a look at that as part of the commit.
2. I think it would be helpful to add a comment explaining why
CheckIndexCompatible() is calling
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-07-07 18:44:49 | Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE |
| Previous Message | Robert Haas | 2011-07-07 18:15:38 | Re: Latch implementation that wakes on postmaster death on both win32 and Unix |