From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers. |
Date: | 2012-05-24 20:11:22 |
Message-ID: | CA+TgmoaTzypcTFMibodSB0jAWOjo75mfgm7HmAjk0KAu0uDw8g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, May 24, 2012 at 2:52 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, May 23, 2012 at 2:28 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> Is there plan to implement such external functions before 9.2 release?
>>> If not, keepalive protocol seems to be almost useless because there is
>>> no use of it for a user and the increase in the number of packets might
>>> increase the replication performance overhead slightly. No?
>
>> Good point. IMHO, this shouldn't really have been committed like
>> this, but since it was, we had better fix it, either by reverting the
>> change or forcing an initdb to expose the functionality.
>
> I see no reason to rip the code out if we have plans to make use of it
> in the near future. I am also not for going back into development mode
> on 9.2, which is what adding new functions now would amount to. What's
> wrong with leaving well enough alone? It's not like there is no
> unfinished work anywhere else in Postgres ...
So, extra TCP overhead for no user-visible benefit doesn't bother you?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2012-05-24 21:36:17 | pgsql: Remove PL/Perl null array 9.2 release note item, per Andrew Duns |
Previous Message | Tom Lane | 2012-05-24 18:52:05 | Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers. |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Janes | 2012-05-24 20:16:53 | Re: 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile |
Previous Message | Bruce Momjian | 2012-05-24 19:55:21 | Re: Missing optimization when filters are applied after window functions |