| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com>, Ian Barwick <ian(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Jim Nasby <jim(at)nasby(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Subject: | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Date: | 2014-11-20 20:50:21 |
| Message-ID: | CA+TgmoaJP3xKpGCABp3ptoy9oTKmg6xjauXFH1ZuKNUr-z-4NQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 20, 2014 at 3:20 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Thu, Nov 20, 2014 at 12:14 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Seems fine to me. If you typed relid rather than indexrelid or key
>> rather than indkey, that's a thinko, not a typo. ikey for indkey
>> could plausible be a typo, though you'd have to be having a fairly bad
>> day at the keyboard.
>
> I can tell that I have no chance of convincing you otherwise. While I
> think you're mistaken to go against the precedent set by git, you're
> the one with the commit bit, and I think we've already spent enough
> time discussing this. So default costings it is.
I've got a few +1s, too, if you notice.
I'm willing to be outvoted, but not by a majority of one.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-11-20 20:57:24 | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Previous Message | Robert Haas | 2014-11-20 20:47:39 | Re: group locking: incomplete patch, just for discussion |