Re: [RFC] Should smgrtruncate() avoid sending sinval message for temp relations

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: MauMau <maumau307(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [RFC] Should smgrtruncate() avoid sending sinval message for temp relations
Date: 2014-08-12 15:04:00
Message-ID: CA+TgmoaD8y=ONGBy_f_7UhRb9NgKZcPNyi5B1RZe5-q+2uhEMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 11, 2014 at 7:40 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Fri, Aug 8, 2014 at 10:30 AM, MauMau <maumau307(at)gmail(dot)com> wrote:
>>> I've tracked down the real root cause. The fix is very simple. Please
>>> check the attached one-liner patch.
>
>> I'd support back-porting that commit to 9.1 and 9.2 as a fix for this
>> problem. As the commit message says, it's dead simple.
>
> While I have no great objection to back-porting Heikki's patch, it seems
> like a very large stretch to call this a root-cause fix. At best it's
> band-aiding one symptom in a rather fragile way.

Yeah, that's true, but I'm not clear that we have another
back-patchable fix, so doing something almost-certainly-harmless to
alleviate the immediate pain seems worthwhile.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-08-12 15:06:55 Re: [RFC] Should smgrtruncate() avoid sending sinval message for temp relations
Previous Message Robert Haas 2014-08-12 14:58:42 Re: jsonb format is pessimal for toast compression