From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Alex Goncharov <alex-goncharov(at)comcast(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: libpq: PQcmdStatus, PQcmdTuples signatures can be painlessly improved |
Date: | 2011-12-13 15:51:54 |
Message-ID: | CA+Tgmoa9YKtbHgpBGd-Jtnz12yxdUjQ8WizUaLJp04r341etuw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Dec 13, 2011 at 7:55 AM, Alex Goncharov
<alex-goncharov(at)comcast(dot)net> wrote:
> If the above change causes a warning in a client code, so much the
> better: the client code is doing something unreasonable like the "*s"
> assignment in my example above.
Or they just haven't bothered to decorate their entire code-base with
const declarations.
I suppose it's probably worth doing this, but I reserve the right to
be unexcited about it. At a minimum, I dispute the application of the
term "painless" to any change involving const.
If you want this patch to be considered for application, you should
post an updated patch which includes the necessary doc changes and add
a link to it here:
https://commitfest.postgresql.org/action/commitfest_view/open
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Merlin Moncure | 2011-12-13 15:53:24 | Re: Command Triggers |
Previous Message | Tom Lane | 2011-12-13 15:43:26 | Re: LibreOffice driver 1: Building libpq with Mozilla LDAP instead of OpenLDAP |