Re: proposal: rounding up time value less than its unit.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomonari Katsumata <t(dot)katsumata1122(at)gmail(dot)com>, David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: rounding up time value less than its unit.
Date: 2014-09-23 14:16:26
Message-ID: CA+Tgmoa68cWssqOc4Ew3Cvj61cYgjBaDguOgESSPVJRWt_OT4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 23, 2014 at 1:23 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> Stephen Frost <sfrost(at)snowman(dot)net> writes:
>> > To clarify- we'll simply swap from (essentially) floor() to ceil() for
>> > handling all GUC_with_unit to internal_unit conversions, document that,
>> > and note it in the release notes as a possible behavior change and move
>> > on.
>>
>> Worksforme.
>
> Great, thanks. I'll wait a couple days to see if anyone else wants to
> voice a concern.
>
> Tomonari, don't worry about updating the patch (unless you really want
> to) as I suspect I'll be changing around the wording anyway. No
> offense, please, but I suspect English isn't your first language and
> it'll be simpler for me if I just handle it. Thanks a lot for the bug
> report and discussion and I'll be sure to credit you for it in the
> commit.

Three people have voted for making it an *error* to supply a value
that needs to be rounded, instead of changing the rounding behavior.
There are not three votes for any other proposal. (This may still be
an improvement over the current behavior, though.)

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-09-23 14:29:34 Re: proposal: rounding up time value less than its unit.
Previous Message Stephen Frost 2014-09-23 14:14:30 Re: RLS feature has been committed