| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |
| Date: | 2013-07-17 19:30:32 |
| Message-ID: | CA+TgmoZzQuQz9Ks1gtftaYoJXomLcXb2Xrqv7cYhx+3TyFSTDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 12, 2013 at 9:15 AM, Amit kapila <amit(dot)kapila(at)huawei(dot)com> wrote:
> The sleep is used to ensure the effects of pg_reload_conf() can be visible.
That strikes me as almost certain to result in random regression test
failures. My experience, as a man who helps to maintain a very large
suite of regression tests, is that all time-based assumptions about
how long it will take some operation to complete are false, and that
failures are a lot more frequent than you think they will be.
This feature doesn't strike me as a good candidate for regression
testing anyway. Keep in mind that people are intended to be able to
run make installcheck against a deployed system without messing it up.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2013-07-17 20:05:32 | Re: Return of "can't paste into psql" issue |
| Previous Message | Andrew Dunstan | 2013-07-17 19:20:28 | Re: Return of "can't paste into psql" issue |