From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Merlin Moncure <mmoncure(at)gmail(dot)com>, Daniel Farina <daniel(at)heroku(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Some interesting news about Linux 3.12 OOM |
Date: | 2013-09-19 16:08:54 |
Message-ID: | CA+TgmoZwpOk+PpCqXykWE=gWF8uBhc9aG4eyMwNYE1-c7PEW2A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Sep 19, 2013 at 12:02 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> The "problem" is that it's not just about malloc() (aka brk() and
> mmap()) and friends. It's about many of the other systemcalls. Like
> e.g. send() to name one of the more likely ones.
*shrug*
If you're using for send() and not testing for a -1 return value,
you're writing amazingly bad code anyway. And if you ARE testing for
-1, you'll probably do something at least mildly sensible with a
not-specifically-foreseen errno value, like print a message that
includes %m. That's about what we'd probably do, and I have to
imagine what most people would do.
I'm not saying it won't break anything to return a proper error code;
I'm just saying that sending SIGKILL is worse.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2013-09-19 16:23:07 | Re: Some interesting news about Linux 3.12 OOM |
Previous Message | Robert Haas | 2013-09-19 16:05:35 | Re: logical changeset generation v6 |