Re: [v9.1] sepgsql - userspace access vector cache

On Fri, Aug 19, 2011 at 11:46 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Kohei Kaigai <Kohei(dot)Kaigai(at)EMEA(dot)NEC(dot)COM> writes:
>>> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
>>> Well, they should get at least a warning from referencing undefined
>>> functions, no?
>
>> Yes. User should notice warning messages due to undefined symbols.
>> I'm not certain whether it makes sense to add -Werror here, or not.
>
> Hmm.  That would help catch the problem, but I'm a bit uncomfortable
> with adding -Werror in relatively new code.  On the other hand, it's
> not like we expect sepgsql to work on a wide variety of systems, so
> maybe it'd be OK.
>
> On the whole I don't think it's worth messing with the cflags for this.

Yeah, I agree.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company