| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: dynahash replacement for buffer table |
| Date: | 2014-10-14 15:36:39 |
| Message-ID: | CA+TgmoZw+DaHA+Pf1A26Vh57zp4hE0di_3AJx-0vU6wcdRt5Vw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 14, 2014 at 11:31 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> It doesn't look particularly dangerous to me. Famous last words.
>
>> Basically, I think what we're doing right now is holding the buffer
>> mapping lock so that the buffer can't be renamed under us while we're
>> pinning it.
>
> What I'm afraid of is that there's hidden assumptions about the
> consistency provided by the mapping locks.
That's certainly worth checking for, but I think the only code that
needs to be checked is the code that would formerly have run while
holding said lock. And there isn't that much of that.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lucas Lersch | 2014-10-14 16:08:31 | Buffer Requests Trace |
| Previous Message | Andres Freund | 2014-10-14 15:31:20 | Re: WIP: dynahash replacement for buffer table |