| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Allow Pin/UnpinBuffer to operate in a lockfree manner. |
| Date: | 2016-04-18 11:34:34 |
| Message-ID: | CA+TgmoZsjmn6xtFepN86bb8DcTzyARUT+T5wpYBpr-9rLdwvGg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Apr 17, 2016 at 12:01 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> Allow Pin/UnpinBuffer to operate in a lockfree manner.
>
> Now that I've had some occasion to look around in bufmgr.c, I am very
> unhappy that there are still boatloads of comments talking about a buffer
> header's spinlock, when there is in fact no spinlock anymore. Please
> expend some effort on making this less confusing for the next hacker.
> Maybe make those comments talk about a "lock bit" instead?
I was actually going to complain about this, too. I noticed it over
the weekend when noodling around with another patch. I'm not sure
exactly how it should be revised, but I find the current state of
things confusing.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-18 13:17:46 | Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. |
| Previous Message | Michael Paquier | 2016-04-18 04:37:21 | Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-04-18 11:43:30 | Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE. |
| Previous Message | Amit Langote | 2016-04-18 08:55:15 | Re: Declarative partitioning |