Re: [PATCH] hstore_to_json: empty hstores must return empty json objects

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Oskari Saarenmaa <os(at)ohmu(dot)fi>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] hstore_to_json: empty hstores must return empty json objects
Date: 2013-10-17 12:20:38
Message-ID: CA+TgmoZjMKZ_k5o6j4cpynwjx2jcoj8TTxtP0yiVcYn5m6U=7g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 16, 2013 at 12:02 PM, Oskari Saarenmaa <os(at)ohmu(dot)fi> wrote:
> hstore_to_json used to return an empty string for empty hstores, but
> that is not correct as an empty string is not valid json and calling
> row_to_json() on rows which have empty hstores will generate invalid
> json for the entire row. The right thing to do is to return an empty
> json object.

Hmm. This sure looks like a bug to me.

Anyone think otherwise?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-10-17 12:22:52 Re: Auto-tuning work_mem and maintenance_work_mem
Previous Message Robert Haas 2013-10-17 12:18:32 Re: ERROR : 'tuple concurrently updated'