Re: initdb: Improve error recovery.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Mats Erik Andersson <bsd(at)gisladisker(dot)se>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: initdb: Improve error recovery.
Date: 2014-12-02 16:22:07
Message-ID: CA+TgmoZ_XcTOL2K1sv3aMfXe3Xxo4WE1cbp9i1vH0DiVsaJg4g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 27, 2014 at 7:28 AM, Mats Erik Andersson <bsd(at)gisladisker(dot)se> wrote:
> I would like to improve error recovery of initdb when the
> password file is empty. The present code declares "Error 0"
> as the cause of failure. It suffices to use ferrer() since
> fgets() returns NULL also at a premature EOF.
>
> In addition, a minor case is the need of a line feed in
> order to print the error message on a line of its own
> seems desirable.
>
> Best regards,
> Mats Erik Andersson

Please add your patch here so that it doesn't get forgotten about:

https://commitfest.postgresql.org/action/commitfest_view/open

Also, note that the PostgreSQL project prefers for patches to be
attached rather than inline, as mailers have a tendency to mangle
them.

Thanks,

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-12-02 16:29:17 Re: superuser() shortcuts
Previous Message Christoph Berg 2014-12-02 15:59:37 Re: test_shm_mq failing on mips*