Re: pg_dump insert with column names speedup

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump insert with column names speedup
Date: 2013-10-04 17:21:16
Message-ID: CA+TgmoZUtmcjsnDuEMJSi3_WSW1T242turZixXmdtUp28H0xSg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 4, 2013 at 11:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
>> Here's a small patch which greatly increases the speed of
>> pg_dump --column-inserts.
>
> The reason why no one's paid any attention to the speed of that code path
> is that if you care about dump/restore speed, you should be using the COPY
> code paths instead. Is it really worth adding code and complexity to
> pg_dump for this?

One possible reason to care about this is if you're trying to move
data to another database. The INSERT format is more portable.

Also, this isn't really adding any net code or complexity AFAICS.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2013-10-04 17:39:25 Re: pg_dump insert with column names speedup
Previous Message Tom Lane 2013-10-04 15:28:57 Re: pg_dump insert with column names speedup