Re: WIP: dynahash replacement for buffer table

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: dynahash replacement for buffer table
Date: 2015-01-27 04:20:36
Message-ID: CA+TgmoZDHHjQxsn18pEeDYnNXMg39R9yrGnmq7kuYcNwm-JadA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This developed a slight merge conflict. I've rebased the attached
version, and I also took the step of getting rid of buf_table.c, as I
think I proposed somewhere upthread. This avoids the overhead of
constructing a BufferTag only to copy it into a BufferLookupEnt, plus
some function calls and so forth. A quick-and-dirty test suggests
this might not have cut down on the 1-client overhead much, but I
think it's worth doing anyway: it's certainly saving a few cycles, and
I don't think it's complicating anything measurably.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
chash-buftable-v2.patch text/x-patch 81.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip kumar 2015-01-27 05:08:24 Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]
Previous Message Michael Paquier 2015-01-27 02:52:57 Re: Windows buildfarm animals are still not happy with abbreviated keys patch