| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |
| Date: | 2012-10-12 20:21:56 |
| Message-ID: | CA+TgmoZ4Sn7AZpSCybB+BOUcMs229RP_3mPVEOMUJ6wDhQK3Pg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 10, 2012 at 8:02 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Oct 11, 2012 at 3:36 AM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>> 2012-10-10 18:23 keltezéssel, Fujii Masao írta:
>>> When tar output format is specified together with -R option, recovery.conf
>>> is
>>> not included in base.tar. I think it should.
>>
>>
>> Why? This patch only promises to write the recovery.conf into the
>> directory specified with -D.
>
> Because it's more user-friendly. If recovery.conf is not included in base.tar,
> when base.tar is extracted to disk to use the backup, a user always needs
> to copy recovery.conf to the extracted directory. OTOH if it's included in
> base.tar, such copy operation is not required and we can simplify the
> procedures to use the backup a bit.
+1.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-10-12 20:26:04 | Re: Truncate if exists |
| Previous Message | Bruce Momjian | 2012-10-12 20:19:17 | Re: Improving the performance of psql tab completion |