Re: BUG #8167: false EINVAL -22 for opening a file

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: nelson(at)monkey(dot)org, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: BUG #8167: false EINVAL -22 for opening a file
Date: 2013-05-17 00:12:27
Message-ID: CA+TgmoZ4JPsb5tv31KLqkupyMiUeXHzqVyYueMsux7-R4EA5wg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, May 16, 2013 at 11:55 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I've not really reviewed fd.c for other instances of the same bug,
> but I do see some places where there are DO_DB(...) debug calls in
> places where errno had better not change. I'm thinking maybe we should
> improve that macro to include save/restore errno. Or else rip that
> stuff out entirely --- I've sure never built this code with FDDEBUG
> set, has anyone else?

Not me.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2013-05-17 00:23:02 Re: Inconsistency between TO_CHAR() and TO_NUMBER()
Previous Message Tom Lane 2013-05-16 22:00:34 Re: pg_ctl -D "/absolute/path" -m fast restart - doesn't work in some cases

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-05-17 00:16:57 Re: Logging of PAM Authentication Failure
Previous Message Robert Haas 2013-05-17 00:11:11 Re: counting algorithm for incremental matview maintenance