| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reviewing freeze map code |
| Date: | 2016-06-03 14:03:39 |
| Message-ID: | CA+TgmoZ1k4jnbkZTnbRmCA4T1RVGd0dqaHm6Y0RoT2knN6qm_A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 2, 2016 at 11:24 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> Attached patch optimises skipping pages logic so that blkno can jump to
> next_unskippable_block directly while counting the number of all_visible
> and all_frozen pages. So we can avoid double checking visibility map.
I think this is 9.7 material. This patch has already won the
"scariest patch" tournament. Changing the logic more than necessary
at this late date seems like it just increases the scariness. I think
this is an opportunity for further optimization, not a defect.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh berkus | 2016-06-03 14:14:42 | Re: Rename max_parallel_degree? |
| Previous Message | Robert Haas | 2016-06-03 14:02:55 | Re: Reviewing freeze map code |