Re: [PATCH] Fix search_path default value separator.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Christoph Martin <christoph(dot)r(dot)martin(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix search_path default value separator.
Date: 2014-07-14 14:58:46
Message-ID: CA+TgmoYxFYKY017yrqEZMQb7Miv=twR9PWpo3CUsAoxRiGDe6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 11, 2014 at 6:09 AM, Christoph Martin
<christoph(dot)r(dot)martin(at)gmail(dot)com> wrote:
> I noticed a minor inconsistency with the search_path separator used in the
> default configuration.
>
> The schemas of any search_path set using `SET search_path TO...` are
> separated by ", " (comma, space), while the default value is only separated
> by "," (comma).
>
> The attached patch against master changes the separator of the default value
> to be consistent with the usual comma-space separators, and updates the
> documentation of `SHOW search_path;` accordingly.
>
> This massive three-byte change passes all 144 tests of make check.

Heh. I'm not particularly averse to changing this, but I guess I
don't see any particular benefit of changing it either. Either comma
or comma-space is a legal separator, so why worry about it?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Martin 2014-07-14 15:20:15 Re: [PATCH] Fix search_path default value separator.
Previous Message Amit Kapila 2014-07-14 14:51:17 Re: Use unique index for longer pathkeys.