| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Euler Taveira de Oliveira <euler(at)timbira(dot)com(dot)br> |
| Subject: | Re: Is this a bug? |
| Date: | 2014-08-22 19:12:47 |
| Message-ID: | CA+TgmoYpnSwjhfN2v9tskeBYWruV-G3pYrb4MDQSPmxPJtHm9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 22, 2014 at 2:33 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> Yes, you remember well. I will have to find a different way for
>> pg_upgrade to call a no-op ALTER TABLE, which is fine.
>
> Looking at the ALTER TABLE options, I am going to put this check in a
> !IsBinaryUpgrade block so pg_upgrade can still use its trick.
-1, that's really ugly.
Maybe the right solution is to add a form of ALTER TABLE that is
specifically defined to do only this check. This is an ongoing need,
so that might not be out of line.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-08-22 19:15:15 | Re: [PATCH] Incremental backup: add backup profile to base backup |
| Previous Message | Andres Freund | 2014-08-22 18:54:54 | Re: Is this a bug? |