| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tv(at)fuzzy(dot)cz> |
| Subject: | Re: TABLESAMPLE patch |
| Date: | 2015-04-01 16:38:44 |
| Message-ID: | CA+TgmoYgLBtZ6so9C7DtAqA_0Y2Lurqa1rNmFVM6PxMwTa4SmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 1, 2015 at 12:15 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
> REPEATABLE is mandated by standard. I did try for quite some time to make it
> unreserved but was not successful (I can only make it unreserved if I make
> it mandatory but that's not a solution). I haven't been in fact even able to
> find out what it actually conflicts with...
Yeah, that can be hard to figure out. Did you run bison with -v and
poke around in gram.output?
> METHOD is something I added. I guess we could find a way to name this
> differently if we really tried. The reason why I picked METHOD was that I
> already added the same unreserved keyword in the sequence AMs patch and in
> that one any other name does not really make sense.
I see. Well, I guess if we've got more than one use for it it's not so bad.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-04-01 16:39:36 | Re: How about to have relnamespace and relrole? |
| Previous Message | Heikki Linnakangas | 2015-04-01 16:24:21 | Re: Move inet_gist to right place in pg_amproc |