| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Mark Cave-Ayland <mark(dot)cave-ayland(at)ilande(dot)co(dot)uk>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: Commitfest problems |
| Date: | 2014-12-16 16:42:56 |
| Message-ID: | CA+TgmoYaksTr7XNb-myfbYEYivDKuFvfBA85agy0SsZszg8-KA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 16, 2014 at 12:18 AM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> On 12/15/2014 07:34 PM, Andres Freund wrote:
>> On 2014-12-15 16:14:30 -0800, Josh Berkus wrote:
>>> Read the thread on this list where I suggested crediting reviewers in
>>> the release notes.
>>
>> Man. You're equating stuff that's not the same. You didn't get your way
>> (and I'm tentatively on your side onthat one) and take that to imply
>> that we don't want more reviewers.
>
> During that thread a couple people said that novice reviewers added no
> value to the review process, and nobody argued with them then. I've
> also been told this to my face at pgCon, and when I've tried organizing
> patch review events. I got the message, which is why I stopped trying
> to get new reviewers.
I think what was said is that it isn't very useful to have reviewers
who just report that the patch applies and passes make check. But any
review that does any study of the code, or finds a bug in the
functionality, or reports that the patch does NOT apply and/or pass
make check, or suggests a way that the documentation could be
improved, or fixes a typo in a comment, or diagnoses a whitespace
error is useful. Summarizing that as "novice reviewers added no value
to the review process" is like summarizing the plot of Superman as
"alien invades earth".
> And frankly: if we're opposed to giving credit to patch reviewers, we're
> opposed to having them.
This is also an incredibly misleading summary of what the real issue
was, as I just said in my previous email. We do credit reviewers,
routinely, and have for years. We have not reached an agreement on
whether or exactly how to credit them in the release notes. You may
think that there's no value in having your name show up in a commit
log message and that the release notes are the only thing that counts,
but I don't think everyone feels that way. I *still* get a kick out
of it every time somebody types my name into one of those messages.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Colson | 2014-12-16 16:43:46 | Re: Commitfest problems |
| Previous Message | Heikki Linnakangas | 2014-12-16 16:41:12 | Re: pg_basebackup vs. Windows and tablespaces |