From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgindent |
Date: | 2016-04-27 15:51:42 |
Message-ID: | CA+TgmoYaQJ42qwurx2X_gwU-uBFBNv9mAdG1Gk12TDw0ikD_8Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 27, 2016 at 11:45 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Yes, that makes sense. That way other can easily look at "their" code,
> to see whether it can be made more pgindent resistant ;)
Right.
>> It mostly just adds new typedefs that have
>> appeared over the last year, but it also realphabetizes the file -
>> some things that were added incrementally seem to have ended up in
>> what is, at least according to what sort likes to do on my machine,
>> the wrong place in the file.
>
> Is it just me, or is the sort order in that file a bit confusing? The
> whole thing about upper and lower case being separated seems to make it
> much harder than necessary to manually insert something in the right
> place..
Except for recently-manually-added entries, it seems to match what
sort wants to do on my system exactly. Which seems good.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-04-27 15:56:57 | Re: pgindent |
Previous Message | Andres Freund | 2016-04-27 15:51:40 | Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE. |