| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Christian Kruse <christian(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: show relation and tuple infos of a lock to acquire |
| Date: | 2014-03-18 19:38:42 |
| Message-ID: | CA+TgmoY_2KAzzVqUz3EU5fjmkzzv+G_AOCtQfiAgqP=aPzFU_w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 18, 2014 at 12:53 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> Please see my reply to Robert. My proposal (in form of a patch) is
>> while operating on tuple (0,2) in table "foo": updating tuple
>> Would this work for you?
>
> It's pretty lousy from a readability standpoint, even in English;
> I shudder to think what it might come out as after translation.
>
> I think the enum idea you floated is probably worth doing. It's
> certainly no more complex than passing a string, no?
+1. We've done similar things in tablecmds.c.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2014-03-18 19:44:05 | Re: plpgsql.warn_shadow |
| Previous Message | Marko Tiikkaja | 2014-03-18 19:38:07 | Re: plpgsql.warn_shadow |