Re: Extra functionality to createuser

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Christopher Browne <cbbrowne(at)gmail(dot)com>, Sameer Thakur <samthakur74(at)gmail(dot)com>, PostgreSQL Mailing Lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extra functionality to createuser
Date: 2013-12-09 18:50:26
Message-ID: CA+TgmoYZYb6KSOuC-qQ0xW_DyHAbuCqyv7QgRkNfCui5jgdWrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 7, 2013 at 11:39 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Dec 6, 2013 at 10:31 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> On Wed, 2013-11-20 at 11:23 -0500, Christopher Browne wrote:
>>> I note that similar (with not quite identical behaviour) issues apply
>>> to the user name. Perhaps the
>>> resolution to this is to leave quoting issues to the administrator.
>>> That simplifies the problem away.
>>
>> How about only one role name per -g option, but allowing the -g option
>> to be repeated?
>
> I think that might simplify the problem and patch, but do you think
> it is okay to have inconsistency
> for usage of options between Create User statement and this utility?

Yes. In general, command-line utilities use a very different syntax
for options-passing that SQL commands. Trying to make them consistent
feels unnecessary or perhaps even counterproductive. And the proposed
syntax is certainly a convention common to many other command-line
utilities, so I think it's fine.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2013-12-09 18:51:01 Re: plpgsql_check_function - rebase for 9.3
Previous Message Tom Lane 2013-12-09 18:47:16 Re: ANALYZE sampling is too good