From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Geoghegan <peter(at)2ndquadrant(dot)com>, Ants Aasma <ants(at)cybertec(dot)at>, Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Patch: add timing of buffer I/O requests |
Date: | 2012-04-28 23:26:02 |
Message-ID: | CA+TgmoYYHwh-vS8AW-cQQpwXdMR31ATiuZ04BPGAvOY5jCB9UQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Apr 28, 2012 at 12:49 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> ... You might want to revisit the issue of how the new
>> columns in pg_stat_statements are named, as well. I am not sure I'm
>> happy with that, but neither am I sure that I know what I'd like
>> better. It's not too clear that the timing is specifically for data
>> block reads and writes, for example.
>
> Well, the names "time_read" and "time_write" are certainly out of step
> with every other stats view in the system; everyplace else, such columns
> are named "something_time" (and even in this view itself the other
> timing column is "total_time", not "time_total"). So that's got to
> change. We could just reverse the word order to "read_time" and
> "write_time", or we could do something like "buf_read_time" or
> "data_read_time". IIUC block_read_time/block_write_time in the
> pg_stat_database view are database-wide totals for the same numbers, so
> perhaps the pg_stat_statements column names should be consistent with
> those. I am kinda wondering though why those columns spell out "block"
> where every single other column name in the stats views uses the
> abbreviation "blk".
I like the idea of including the word block in there. I don't think
it was probably a terribly good idea to abbreviate that to blk
everywhere, but at this point it's probably better to be consistent,
sigh.
As for track_iotiming -> track_io_timing, I'm fine with that as well.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-04-28 23:41:02 | Re: smart shutdown at end of transaction (was: Default mode for shutdown) |
Previous Message | Robert Haas | 2012-04-28 23:24:09 | Re: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap |