| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Craig Ringer <ringerc(at)ringerc(dot)id(dot)au>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Changeset Extraction v7.9.1 |
| Date: | 2014-03-17 10:55:28 |
| Message-ID: | CA+TgmoYKshsx_APXj3ht9AB8xn-_FJBVfdr=3Mwg1Mf9tsnGUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 12, 2014 at 2:06 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> Attached are the collected remaining patches. The docs might need
> further additions, but it seems better to add them now.
A few questions about pg_recvlogical:
- There doesn't seem to be any provision for this tool to ever switch
from one output file to the next. That seems like a practical need.
One idea would be to have it respond to SIGHUP by reopening the
originally-named output file. Another would be to switch, after so
many bytes, to filename.1, then filename.2, etc.
- It confirms the write and flush positions, but doesn't appear to
actually flush anywhere.
- While I quite agree with your desire for stringinfo in src/common,
couldn't you use the roughly-equivalent PQExpBuffer facilities in
libpq instead?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-03-17 11:27:06 | Re: Changeset Extraction v7.9.1 |
| Previous Message | Thom Brown | 2014-03-17 10:52:07 | Various typos |