Re: Re: Proposal/design feedback needed: WITHIN GROUP (sql standard ordered set aggregate functions)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Atri Sharma <atri(dot)jiit(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com>
Subject: Re: Re: Proposal/design feedback needed: WITHIN GROUP (sql standard ordered set aggregate functions)
Date: 2013-09-19 14:11:01
Message-ID: CA+TgmoYAW30pZZgoMMXY0GwRLtqDGo+3pcQYy44S619Z0nzLEg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 17, 2013 at 2:27 PM, Andrew Gierth
<andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
>>>>>> "Robert" == Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>
> >> Someone should do the same in WaitForBackgroundWorkerStartup so
> >> that building with -Werror works.
>
> Robert> I don't get a warning there. Can you be more specific about
> Robert> the problem?
>
> bgworker.c: In function 'WaitForBackgroundWorkerStartup':
> bgworker.c:866: warning: 'pid' may be used uninitialized in this function

Does the attached patch fix it for you?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
bgworker-wait-fix.patch application/octet-stream 916 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-09-19 14:12:24 Re: Some interesting news about Linux 3.12 OOM
Previous Message Robert Haas 2013-09-19 14:02:31 Re: logical changeset generation v6