From: | "Claudio Natoli" <claudio(dot)natoli(at)memetrics(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Magnus Hagander" <mha(at)sollentuna(dot)net> |
Cc: | <pgsql-hackers(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Bad bug in fopen() wrapper code |
Date: | 2006-09-25 00:04:29 |
Message-ID: | C9A33A2803C7F3479A02A333328A174756CAB2@ewell.memetrics.local |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Hello guys,
it's been a while, but...
> What's bugging me is that 0 and O_EXCL give the same answer, and
> O_TRUNC and O_TRUNC | O_EXCL give the same answer,
This is ok, as (iirc) O_EXCL only has effect in the presence of O_CREAT.
(a comment to this effect would help here, as well as perhaps links to the CreateFile and open specs)
> but O_CREAT and O_CREAT | O_EXCL give different answers,
> as do O_CREAT | O_TRUNC and O_CREAT | O_TRUNC | O_EXCL.
See above.
> I'm also pretty suspicious of both O_CREAT | O_EXCL and
> O_CREAT | O_TRUNC | O_EXCL giving the same answer.
O_CREAT | O_EXCL is effectively "create, but fail if the file exists", which is the behaviour specified by CREATE_NEW. Adding O_TRUNC to this combination, which can only apply to a successfully opened existent file, can have no impact afaics.
Cheers,
Claudio
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-09-25 00:36:16 | Re: pgsql: We're going to have to spell dotless i |
Previous Message | Gevik Babakhani | 2006-09-25 00:01:17 | TODO: Fix CREATE CAST on DOMAIN Part II |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeremy Drake | 2006-09-25 01:21:18 | Re: [HACKERS] large object regression tests |
Previous Message | Jeremy Drake | 2006-09-24 22:19:12 | Re: [HACKERS] large object regression tests |