Re: record identical operator - Review

From: Steve Singer <steve(at)ssinger(dot)info>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: record identical operator - Review
Date: 2013-10-03 13:59:03
Message-ID: BLU0-SMTP82D244674ADD8D38173A73DC170@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09/30/2013 09:08 AM, Kevin Grittner wrote:
> Steve Singer <steve(at)ssinger(dot)info> wrote:
>
>> How about
>>
>> To support matching of rows which include elements without a default
>> B-tree operator class, the following operators are defined for composite
>> type comparison:
>> <literal>*=</>,
>> <literal>*&lt;&gt;</>,
>> <literal>*&lt;</>,
>> <literal>*&lt;=</>,
>> <literal>*&gt;</>, and
>> <literal>*&gt;=</>.
>>
>> These operators compare the internal binary representation of the two
>> rows. Two rows might have a different binary representation even
>> though comparisons of the two rows with the equality operator is true.
>> The ordering of rows under these comparision operators is deterministic
>> but not otherwise meaningful. These operators are used internally for
>> materialized views and might be useful for other specialized purposes
>> such as replication but are not intended to be generally useful for
>> writing queries.
> I agree that's an improvement. Thanks!

Are there any outstanding issues on this patch preventing it from being
committed?
I think we have discussed this patch enough such that we now have
consensus on proceeding with adding a record identical operator to SQL.
No one has objected to the latest names of the operators.

You haven't adjusted the patch to reduce the duplication between the
equality and comparison functions, if you disagree with me and feel that
doing so would increase the code complexity and be inconsistent with how
we do things elsewhere that is fine.

Steve

> --
> Kevin Grittner
> EDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-10-03 14:00:28 Re: insert throw error when year field len > 4 for timestamptz datatype
Previous Message Andres Freund 2013-10-03 13:33:04 Re: Wait free LW_SHARED acquisition