Re: CREATE REPLICATION SLOT fails on a timeout

From: Steve Singer <steve(at)ssinger(dot)info>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CREATE REPLICATION SLOT fails on a timeout
Date: 2014-05-16 21:02:33
Message-ID: BLU0-SMTP76E5D6291A37B1387D362DC310@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/16/2014 04:43 PM, Andres Freund wrote:
> Hi,
>
> I don't think that's going to cut it though. The creation can take
> longer than whatever wal_sender_timeout is set to (when there's lots of
> longrunning transactions). I think checking whether last_reply_timestamp
> = 0 during timeout checking is more robust.
>
> Greetings,
>
> Andres Freund
>
>

That makes sense.
A patch that does that is attached.

Steve

Attachment Content-Type Size
timeout_nonzero.diff text/x-patch 783 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2014-05-16 21:24:31 Re: SKIP LOCKED DATA (work in progress)
Previous Message Andres Freund 2014-05-16 20:43:31 Re: CREATE REPLICATION SLOT fails on a timeout